linux-kernel - Re: [PATCH] staging: atomisp: isp: fix open brace on new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ves2jc7gPoH6zxNGuoo4ubRe0dBqSR5Y70NtJ8fMxfaRw@mail.gmail.com>
Date: Mon, 14 Jul 2025 18:27:47 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Martin Weidenauer <martin@...denauer.cc>
Cc: Greg KH <gregkh@...uxfoundation.org>, hansg@...nel.org, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, andy@...nel.org, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev, 
	~lkcamp/patches@...ts.sr.ht, koike@...lia.com
Subject: Re: [PATCH] staging: atomisp: isp: fix open brace on new line

On Mon, Jul 14, 2025 at 4:51 PM Martin Weidenauer <martin@...denauer.cc> wrote:
>
> If you mean the indentation in the file, I think it's unfortunately just a messy driver in general.
> I mean I could fix it in another commit in general if you want.

Do not top-post!

The question was about the patch that may not be applied due to wrong
indentation.

> On 14 July 2025 15:24:57 CEST, Greg KH <gregkh@...uxfoundation.org> wrote:
> >On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
> >>      Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> >>      in ia_css_dvs.host.c:277.
> >>
> >>      Signed-off-by: Martin Weidenauer <martin@...denauer.cc>
> >>
> >>      ---
> >>
> >>      Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
> >
> >Odd indentation, how did that happen?



-- 
With Best Regards,
Andy Shevchenko