linux-kernel - Re: [PATCH v2 1/5] drm/sitronix/st7571-i2c: Fix encoder callbacks function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877c0a22g0.fsf@minerva.mail-host-address-is-not-set>
Date: Mon, 14 Jul 2025 17:54:07 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: linux-kernel@...r.kernel.org, ipedrosa@...hat.com, David Airlie
 <airlied@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 1/5] drm/sitronix/st7571-i2c: Fix encoder callbacks
 function names

Marcus Folkesson <marcus.folkesson@...il.com> writes:

Hello Marcus,

> On Mon, Jul 14, 2025 at 12:44:00PM +0200, Javier Martinez Canillas wrote:
>> It seems the driver took some inspiration from ssd130x and some of the
>> functions (encoder callbacks) were not renamed to use a st7571_ prefix.
>
> Outch, shame on me.

On the contrary, I'm glad to know that the ssd130x driver was useful :)

>> 
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>
> Reviewed-by: Marcus Folkesson <marcus.folkesson@...il.com>
>

Thanks for your review!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat