linux-kernel - Re: [PATCH net-next] Bluetooth: btrtl: Fix passing zero to 'ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4dd92668-7e8c-45a8-ac93-8c5a292ab340@web.de>
Date: Mon, 14 Jul 2025 18:10:01 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yue Haibing <yuehaibing@...wei.com>, linux-bluetooth@...r.kernel.org,
 Kai-Heng Feng <kai.heng.feng@...onical.com>,
 Luiz Von Dentz <luiz.dentz@...il.com>, Marcel Holtmann <marcel@...tmann.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] Bluetooth: btrtl: Fix passing zero to 'ERR_PTR'

> If bt_skb_alloc() fails, ret should be -ENOMEM then pass to ERR_PTR().

You would like to achieve a more appropriate error code for another case.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94


…
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1137,8 +1137,10 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
>  
>  	if (btrtl_dev->drop_fw) {
>  		skb = bt_skb_alloc(sizeof(*cmd), GFP_KERNEL);
> -		if (!skb)
> +		if (!skb) {
> +			ret = -ENOMEM;
>  			goto err_free;
> +		}
>  
>  		cmd = skb_put(skb, HCI_COMMAND_HDR_SIZE);
…

Will it be a bit nicer to perform the desired variable assignment
after an additional label like “err_no_mem”?

Regards,
Markus