linux-kernel - Re: [PATCH v3 2/2] rust: update ARef and AlwaysRefCounted call sites to import from sync::aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com>
Date: Mon, 14 Jul 2025 18:49:16 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benno Lossin <lossin@...nel.org>
Cc: Shankari Anand <shankari.ak0208@...il.com>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v3 2/2] rust: update ARef and AlwaysRefCounted call sites
 to import from sync::aref

On Mon, Jul 14, 2025 at 10:49 AM Benno Lossin <lossin@...nel.org> wrote:
>
> We probably want to split this by subsystem and not remove the
> re-exports this cycle. @Miguel what do you think?

Indeed, unless we get quick Acked-bys and so on, it is likely we want
to do this (i.e. the second patch) in 2 kernel cycles.

Shankari: i.e. one cycle that cleans up most of the code (which you
can submit split by subsystem so that each maintainer picks on their
own, which typically helps to get patches merged quicker), and then
another kernel cycle that finally cleans anything new (which ideally
are very few) that was added meanwhile and removes the re-export.

There was recent discussion on this sort of split recently on Tamir's
series, in this subthread, in case it helps:

    https://lore.kernel.org/rust-for-linux/CANiq72kta=Wk=3764A5SzxB6Mq=sJfm9DyMZXFC91ojUSj1TeQ@mail.gmail.com/

Sorry if this is (I think) one of your first series sent -- in Rust
moving types around modules is a bit painful. At least the first patch
should not have this issue.

Thanks!

Cheers,
Miguel