[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9618808a-d63b-4eec-b744-471586e270e2@kernel.org>
Date: Mon, 14 Jul 2025 19:45:22 +0100
From: Quentin Monnet <qmo@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
<martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: Replace deprecated strcpy() with strscpy()
2025-07-14 20:23 UTC+0200 ~ Thorsten Blum <thorsten.blum@...ux.dev>
> strcpy() is deprecated; use strscpy() instead.
>
> No functional changes intended.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
> kernel/bpf/disasm.c | 2 +-
Hi and thank you for the patch,
The disassembler file is also part of bpftool's source code [0][1],
where it is compiled as user space code, and where strscpy() is not
defined. So I'd rather not replace this particular occurrence of
strcpy(). We could add a comment in the file to mention this, though.
Thanks,
Quentin
[0]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/bpf/bpftool/Makefile#n246
[1]:
https://github.com/libbpf/bpftool/blob/v7.5.0/src/kernel/bpf/disasm.c#L340
Powered by blists - more mailing lists