linux-kernel - Re: [PATCH] drm/edp-panel: Add touchscreen panel used by Lenovo X13s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XzjC-+Uz4vpTQf+76uL9_Aad9Zs=qkQKBjadRxUKZgYg@mail.gmail.com>
Date: Mon, 14 Jul 2025 12:40:14 -0700
From: Doug Anderson <dianders@...omium.org>
To: daniel@...cstar.com
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/edp-panel: Add touchscreen panel used by Lenovo X13s

Hi,

On Tue, Jul 1, 2025 at 1:17 AM <daniel@...cstar.com> wrote:
>
> From: Daniel Thompson <daniel@...cstar.com>
>
> After (checks watch) a little over two years I finally investigated the
> boot warning on my Thinkpad X13s and it was caused by the conservative
> timings warning in panel-edp.c . The X13s was sold with a variety of
> different panel versions; I have the 300 nit multi-touch variant.
>
> I have been unable to secure panel documentation so the I copied the
> timings from NV133WUM-N63.
>
> The raw EDID is:
>
> 00 ff ff ff ff ff ff 00 09 e5 84 0a 00 00 00 00
> 1e 1f 01 04 a5 1d 12 78 03 5c 70 a6 51 4c 9c 26
> 0e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 74 3c 80 a0 70 b0 28 40 30 20
> 36 00 1e b3 10 00 00 1a 00 00 00 fd 00 28 3c 4b
> 4b 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 42
> 4f 45 20 48 46 0a 20 20 20 20 20 20 00 00 00 fe
> 00 4e 56 31 33 33 57 55 4d 2d 54 30 31 0a 00 51
>
> Signed-off-by: Daniel Thompson <daniel@...cstar.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 90e8c154a9788ad40e2101fdf39cbd92f2e0773a..9144de974f1e4abdd1af12613238f6f28d98fc41 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1935,6 +1935,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a3e, &delay_200_500_e80, "NV116WHM-N49"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
> +       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a84, &delay_200_500_e50, "NV133WUM-T01"),

Looks fine, but can you send a v2 with the proper sort ordering? 0xa84
should be before 0xac5, I think...

-Doug