linux-kernel - Re: [PATCH] scsi: hisi_sas: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025071456-divisive-kindred-62f2@gregkh>
Date: Mon, 14 Jul 2025 07:32:03 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Khaled Elnaggar <khaledelnaggarlinux@...il.com>, liyihang9@...wei.com,
	James.Bottomley@...senpartnership.com, martin.petersen@...cle.com,
	linux-kernel-mentees@...ts.linux.dev, shuah@...nel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show()
 functions

On Sun, Jul 13, 2025 at 10:58:54AM -0700, Bart Van Assche wrote:
> On 7/12/25 7:43 AM, Greg KH wrote:
> > On Sat, Jul 12, 2025 at 05:28:03PM +0300, Khaled Elnaggar wrote:
> > > Replace scnprintf() with sysfs_emit() in several sysfs show()
> > > callbacks in hisi_sas_v3_hw.c. This is recommended in
> > > Documentation/filesystems/sysfs.rst for formatting values returned to
> > > userspace.
> > 
> > For new users, yes, but what's wrong with these existing calls?  They
> > still work properly, so why change them?
> 
> How about making this explicit in Documentation/filesystems/sysfs.rst?
> I think that would help to stop the steady stream of patches for
> converting existing sysfs show callbacks to sysfs_emit()/sysfs_emit_at().

Patches gladly accepted :)