linux-kernel - Re: [PATCH v2] lib/crypto: arm/poly1305: Remove unneeded empty weak function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFOzbJKf+TJrPBr4+9_+GD8PHG59akFUBE=Dm0az_DkJA@mail.gmail.com>
Date: Mon, 14 Jul 2025 15:36:55 +1000
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, "Jason A . Donenfeld" <Jason@...c4.com>, 
	Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v2] lib/crypto: arm/poly1305: Remove unneeded empty weak function

On Sat, 12 Jul 2025 at 07:28, Eric Biggers <ebiggers@...nel.org> wrote:
>
> Fix poly1305-armv4.pl to not do '.globl poly1305_blocks_neon' when
> poly1305_blocks_neon() is not defined.  Then, remove the empty __weak
> definition of poly1305_blocks_neon(), which was still needed only
> because of that unnecessary globl statement.  (It also used to be needed
> because the compiler could generate calls to it when
> CONFIG_KERNEL_MODE_NEON=n, but that has been fixed.)
>
> Thanks to Arnd Bergmann for reporting that the globl statement in the
> asm file was still depending on the weak symbol.
>
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  lib/crypto/arm/poly1305-armv4.pl | 2 +-
>  lib/crypto/arm/poly1305-glue.c   | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>