linux-kernel - Re: [PATCH v2 2/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250714-magnificent-powerful-nuthatch-afcc01@krzk-bin>
Date: Mon, 14 Jul 2025 08:00:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonas Jelonek <jelonek.jonas@...il.com>
Cc: linux-i2c@...r.kernel.org, 
	Chris Packham <chris.packham@...iedtelesis.co.nz>, Andi Shyti <andi.shyti@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Markus Stockhausen <markus.stockhausen@....de>
Subject: Re: [PATCH v2 2/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for
 RTL9310 support

On Sat, Jul 12, 2025 at 07:42:54PM +0000, Jonas Jelonek wrote:
>  properties:
>    compatible:
> @@ -23,7 +25,14 @@ properties:
>                - realtek,rtl9302c-i2c
>                - realtek,rtl9303-i2c
>            - const: realtek,rtl9301-i2c
> +      - items:
> +          - enum:
> +              - realtek,rtl9311-i2c
> +              - realtek,rtl9312-i2c
> +              - realtek,rtl9313-i2c
> +          - const: realtek,rtl9310-i2c
>        - const: realtek,rtl9301-i2c
> +      - const: realtek,rtl9310-i2c

So these two are just enum.

>  
>    reg:
>      items:
> @@ -35,8 +44,16 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  realtek,mst-id:
> +    $ref: /schemas/types.yaml#/definitions/uint8

uint32

> +    description:
> +      Realtek-internal ID of the I2C controller/master. Only required
> +      for RTL9310 series.

Drop last sentence, redundant.

> +    minimum: 1
> +    maximum: 2
> +
>  patternProperties:
> -  '^i2c@[0-7]$':
> +  '^i2c@([0-9]|1[0-1])$':
>      $ref: /schemas/i2c/i2c-controller.yaml
>      unevaluatedProperties: false
>  

As mentioned last time, missing constraints.

How did you solve this:

"you should clearly narrow this per variant"?

See example schema. It has EXACTLY this case.

https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212

You also need to narrow the number of children.


Best regards,
Krzysztof