linux-kernel - Re: [PATCH v6 0/3] PCI: tegra: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALHNRZ84Xj=_HqrFWnYHdV-A9YM4yu2FhfYgHy4-sR65tsYbUA@mail.gmail.com>
Date: Mon, 14 Jul 2025 01:12:16 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, linux-kernel@...r.kernel.org, 
	linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 0/3] PCI: tegra: Allow building as a module

On Mon, Jun 30, 2025 at 1:31 PM Aaron Kling <webgeek1234@...il.com> wrote:
>
> On Fri, Jun 13, 2025 at 1:17 AM Manivannan Sadhasivam <mani@...nel.org> wrote:
> >
> > On Wed, May 07, 2025 at 10:25:51PM -0500, Aaron Kling via B4 Relay wrote:
> >
> > You should always add the context of the series in the cover letter.
> >
> > > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > > ---
> > > Changes in v6:
> > > - Remove unused debugfs cleanup function, as caught by kernel ci
> > > - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
> > >
> > > Changes in v5:
> > > - Copy commit message exactly word for word on patch 1, as required by reviewer
> > > - Delete remove callback in patch 3, per request
> > > - Don't clean up debugfs, per request, which drops patch 4 entirely
> > > - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
> > >
> > > Changes in v4:
> > > - Updated commit messages for patches 1 and 2, per review
> > > - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
> > >
> > > Changes in v3:
> > > - Add patch to drop remove callback, per request
> > > - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
> > >
> > > Changes in v2:
> > > - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
> > >   building pci-tegra as a module for arm
> > > - Drop module exit to prevent module unloading, as requested
> > > - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
> > >
> > > ---
> > > Aaron Kling (3):
> > >       irqdomain: Export irq_domain_free_irqs
> > >       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
> >
> > I need an ACK from the cpuidle maintainers to take these 3 patches through PCI
> > tree.
>
> Reminder about this series. I'm normally interacting with the tegra
> maintainers, but I don't particularly care which tree it goes through
> as long as something that works gets merged. So, can one of the
> cpuidle maintainers take a quick look through this, please?
>
> Aaron

There's been no responses here for a month. If no cpuidle maintainers
wish to respond, then what?

It makes more sense to me to take this through the tegra tree. But
Thierry had concerns about removing functionality that was confirmed
working. Manivannan, if this was to go through the tegra tree, would
you still block this conversion if it didn't drop the unplug/unload
functionality? There's many existing drivers, including one for newer
tegra archs, that are unloadable modules that would be affected by the
IRQ concern. I don't want to cause friction here, but I do want to get
this merged before the next LTS, so I can use it for my projects.

Aaron