linux-kernel - Re: [PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8d61abb-a6a6-49cd-94c3-f397bb30203e@kernel.org>
Date: Mon, 14 Jul 2025 09:22:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: jiebing.chen@...ogic.com, Jerome Brunet <jbrunet@...libre.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
 jian.xu@...ogic.com, shuai.li@...ogic.com, zhe.wang@...ogic.com
Subject: Re: [PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec

On 14/07/2025 08:10, Krzysztof Kozlowski wrote:
> On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
>> From: jiebing chen <jiebing.chen@...ogic.com>
>>
>> Add S4 SoC tocodec compatibility support.
>>
>> Acked-by: Rob Herring (Arm) <robh@...nel.org>
>> Signed-off-by: Jiebing Chen <jiebing.chen@...ogic.com>
>> ---
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
You responded in private, but that's not how we discuss here. Please
keep all discussions public.

Above form letter means you received feedback at v1 or v2 and you did
not implement it. You did not respond to it, either.

Please go back to v1 or v2 and implement entire feedback.

Best regards,
Krzysztof