linux-kernel - Re: [PATCH v8 02/16] dt-bindings: net: mediatek,net: allow up to 8 IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <222133f7-9483-4e4b-b3fe-90e2e830fcf6@kernel.org>
Date: Mon, 14 Jul 2025 09:41:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: frank-w@...lic-files.de,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Frank Wunderlich <linux@...web.de>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Georgi Djakov <djakov@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Johnson Wang <johnson.wang@...iatek.com>, Arınç ÜNAL
 <arinc.unal@...nc9.com>, Landen Chao <Landen.Chao@...iatek.com>,
 DENG Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com>,
 Daniel Golle <daniel@...rotopia.org>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Felix Fietkau <nbd@....name>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v8 02/16] dt-bindings: net: mediatek,net: allow up to 8
 IRQs

On 07/07/2025 12:43, Frank Wunderlich wrote:
> Hi Angelo,
> 
> Am 7. Juli 2025 12:06:02 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>:
>> Il 07/07/25 09:30, Frank Wunderlich ha scritto:
>>> Am 7. Juli 2025 08:31:11 MESZ schrieb Krzysztof Kozlowski <krzk@...nel.org>:
>>>> On Sun, Jul 06, 2025 at 03:21:57PM +0200, Frank Wunderlich wrote:
>>>>> From: Frank Wunderlich <frank-w@...lic-files.de>
>>>>>
>>>>> Increase the maximum IRQ count to 8 (4 FE + 4 RSS/LRO).
>>>>
>>>> Because? Hardware was updated? It was missing before?
>>>
>>> There is no RSS support in driver yet,so IRQs were not added to existing DTS yet.
>>>
>>
>> That's the problem. It's the hardware that you should've described, not the driver.
>>
>> In short, you should've allowed the interrupts from the get-go, and you wouldn't
>> be in this situation now :-)
> 
> I have not upstreamed MT7981 or MT7986. I also do not want to say anybody else did this wrong.
> I'm happy that MT7986 is working in mainline. It was basicly not taken into account that these IRQs may be needed in future.
> 
> The technical documents are often not complete and we get some information step-by-step while testing.
> Or it was not seen when documents are too large :) many reasons why it was "forgotten to add".
> We use what we get from sdk and docs and try to make it compatible with mainline....no optimal process,but it is like it is.

Then explain in the commit msg that hardware description was incomplete
and was missing this and that.

This is the valid reason for doing the change.

Best regards,
Krzysztof