linux-kernel - RE: [PATCH v3 1/4] net: renesas: rswitch: rename rswitch.c to rswitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11040B37CC8F15CF82B75315FD854A@TYCPR01MB11040.jpnprd01.prod.outlook.com>
Date: Mon, 14 Jul 2025 07:55:54 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Michael Dege <michael.dege@...esas.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>, Paul
 Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Michael Dege
	<michael.dege@...esas.com>, Nikita Yushchenko
	<nikita.yoush@...entembedded.com>, Andrew Lunn <andrew@...n.ch>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: RE: [PATCH v3 1/4] net: renesas: rswitch: rename rswitch.c to
 rswitch_main.c

Hello Michael-san,

> From: Michael Dege, Sent: Thursday, July 10, 2025 9:31 PM
> 
> Adding new functionality to the driver. Therefore splitting into multiple
> c files to keep them manageable. New functionality will be added to
> separate files.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

I think that these Reviewed-by: tags should be placed after your Signed-off-by
because you got these tags after you submitted.

> Signed-off-by: Michael Dege <michael.dege@...esas.com>

Anyway, this patch looks good to me.

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/net/ethernet/renesas/Makefile                      | 1 +
>  drivers/net/ethernet/renesas/{rswitch.c => rswitch_main.c} | 0
>  2 files changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
> index f65fc76f8b4df8dd9f24af836b6dc0772965366f..6222298bb5582b7091cf8de76acb83ac7dd39c11 100644
> --- a/drivers/net/ethernet/renesas/Makefile
> +++ b/drivers/net/ethernet/renesas/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_SH_ETH) += sh_eth.o
>  ravb-objs := ravb_main.o ravb_ptp.o
>  obj-$(CONFIG_RAVB) += ravb.o
> 
> +rswitch-objs := rswitch_main.o
>  obj-$(CONFIG_RENESAS_ETHER_SWITCH) += rswitch.o
> 
>  obj-$(CONFIG_RENESAS_GEN4_PTP) += rcar_gen4_ptp.o
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch_main.c
> similarity index 100%
> rename from drivers/net/ethernet/renesas/rswitch.c
> rename to drivers/net/ethernet/renesas/rswitch_main.c
> 
> --
> 2.49.0