linux-kernel - Re: [PATCH] xfs: replace min & max with clamp() in xfs_max_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ba1a836-c4c9-4e1a-903d-42c8b88b03c4@oracle.com>
Date: Mon, 14 Jul 2025 08:58:59 +0100
From: John Garry <john.g.garry@...cle.com>
To: George Hu <integral@...hlinux.org>, Carlos Maiolino <cem@...nel.org>
Cc: linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: replace min & max with clamp() in
 xfs_max_open_zones()

On 12/07/2025 15:57, George Hu wrote:
> Refactor the xfs_max_open_zones() function by replacing the usage
> of min() and max() macro with clamp() to simplify the code and
> improve readability.
> 
> Signed-off-by: George Hu <integral@...hlinux.org>

FWIW,

Reviewed-by: John Garry <john.g.garry@...cle.com>

> ---
>   fs/xfs/xfs_zone_alloc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> index 01315ed75502..58997afb1a14 100644
> --- a/fs/xfs/xfs_zone_alloc.c
> +++ b/fs/xfs/xfs_zone_alloc.c
> @@ -1133,9 +1133,7 @@ xfs_max_open_zones(
>   	/*
>   	 * Cap the max open limit to 1/4 of available space
>   	 */

Maybe you can keep this comment, but it was pretty much describing the 
code and not explaining the rationale.

> -	max_open = min(max_open, mp->m_sb.sb_rgcount / 4);
> -
> -	return max(XFS_MIN_OPEN_ZONES, max_open);
> +	return clamp(max_open, XFS_MIN_OPEN_ZONES, mp->m_sb.sb_rgcount / 4);
>   }
>   
>   /*