linux-kernel - Re: [PATCH v2 5/8] media: v4l2-common: Introduce v4l2-params.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507140820.LDrwmHML-lkp@intel.com>
Date: Mon, 14 Jul 2025 08:51:30 +0800
From: kernel test robot <lkp@...el.com>
To: Jacopo Mondi <jacopo.mondi@...asonboard.com>,
	Dafna Hirschfeld <dafna@...tmail.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Keke Li <keke.li@...ogic.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Dan Scally <dan.scally@...asonboard.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	Jacopo Mondi <jacopo.mondi@...asonboard.com>
Subject: Re: [PATCH v2 5/8] media: v4l2-common: Introduce v4l2-params.c

Hi Jacopo,

kernel test robot noticed the following build errors:

[auto build test ERROR on a8598c7de1bcd94461ca54c972efa9b4ea501fb9]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacopo-Mondi/media-uapi-Introduce-V4L2-extensible-params/20250710-215847
base:   a8598c7de1bcd94461ca54c972efa9b4ea501fb9
patch link:    https://lore.kernel.org/r/20250710-extensible-parameters-validation-v2-5-7ec8918ec443%40ideasonboard.com
patch subject: [PATCH v2 5/8] media: v4l2-common: Introduce v4l2-params.c
config: x86_64-randconfig-008-20250713 (https://download.01.org/0day-ci/archive/20250714/202507140820.LDrwmHML-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250714/202507140820.LDrwmHML-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507140820.LDrwmHML-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/media/v4l2-core/v4l2-params.o: in function `v4l2_params_buffer_validate':
>> drivers/media/v4l2-core/v4l2-params.c:16: undefined reference to `vb2_plane_vaddr'


vim +16 drivers/media/v4l2-core/v4l2-params.c

    10	
    11	int v4l2_params_buffer_validate(struct device *dev, struct vb2_buffer *vb,
    12					size_t max_size,
    13					v4l2_params_validate_buffer buffer_validate)
    14	{
    15		size_t header_size = offsetof(struct v4l2_params_buffer, data);
  > 16		struct v4l2_params_buffer *buffer = vb2_plane_vaddr(vb, 0);
    17		size_t payload_size = vb2_get_plane_payload(vb, 0);
    18		size_t buffer_size;
    19		int ret;
    20	
    21		/* Payload size can't be greater than the destination buffer size */
    22		if (payload_size > max_size) {
    23			dev_dbg(dev, "Payload size is too large: %zu\n", payload_size);
    24			return -EINVAL;
    25		}
    26	
    27		/* Payload size can't be smaller than the header size */
    28		if (payload_size < header_size) {
    29			dev_dbg(dev, "Payload size is too small: %zu\n", payload_size);
    30			return -EINVAL;
    31		}
    32	
    33		/* Validate the size reported in the parameter buffer header */
    34		buffer_size = header_size + buffer->data_size;
    35		if (buffer_size != payload_size) {
    36			dev_dbg(dev, "Data size %zu and payload size %zu are different\n",
    37				buffer_size, payload_size);
    38			return -EINVAL;
    39		}
    40	
    41		/* Driver-specific buffer validation. */
    42		if (buffer_validate) {
    43			ret = buffer_validate(dev, buffer);
    44			if (ret)
    45				return ret;
    46		}
    47	
    48		return 0;
    49	}
    50	EXPORT_SYMBOL_GPL(v4l2_params_buffer_validate);
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki