linux-kernel - Re: [PATCH v5 2/3] iio: light: add support for veml6046x00 RGBIR color sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHS-B5KmBKX72OZc@mail.your-server.de>
Date: Mon, 14 Jul 2025 10:21:27 +0200
From: Andreas Klinger <ak@...klinger.de>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, lars@...afoo.de,
	javier.carrasco.cruz@...il.com, mazziesaccount@...il.com,
	arthur.becker@...tec.com, perdaniel.olsson@...s.com,
	mgonellabolduc@...onoff.com, muditsharma.info@...il.com,
	clamor95@...il.com, emil.gedenryd@...s.com,
	devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] iio: light: add support for veml6046x00 RGBIR
 color sensor

Hi Andy,

many thanks for the thorough review. One comment below.

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> schrieb am Mo, 26. Mai 23:17:
> > +/**
> > + * struct veml6046x00_data - Private data of driver.
> > + * @regmap:	Regmap definition of sensor.
> > + * @trig:	Industrial-IO trigger.
> > + * @rf:		Regmap field of configuration.
> > + */
> > +struct veml6046x00_data {
> > +	struct regmap *regmap;
> > +	struct iio_trigger *trig;
> > +	struct veml6046x00_rf rf;
> 
> Does pahole agree on the choice of the layout?

This is the output of pahole:

struct veml6046x00_data {
        struct regmap *            regmap;               /*     0     4 */
        struct iio_trigger *       trig;                 /*     4     4 */
        struct veml6046x00_rf      rf;                   /*     8    20 */

        /* size: 28, cachelines: 1, members: 3 */
        /* last cacheline: 28 bytes */
};

I don't see anything wrong or did i miss something?

Best regards,

Andreas


Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)