linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700 binding description and example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6685da47-748a-4d90-ba1f-d7bcf82e8677@kernel.org>
Date: Mon, 14 Jul 2025 10:24:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>, Thomas Gleixner
 <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>,
 Kevin Chen <kevin_chen@...eedtech.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700
 binding description and example

On 14/07/2025 10:23, Krzysztof Kozlowski wrote:
> On 14/07/2025 09:36, Ryan Chen wrote:
>>> Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700
>>> binding description and example
>>>
>>> On 14/07/2025 09:17, Ryan Chen wrote:
>>>> - Update block diagram for better readability and accuracy.
>>>> - Clarify the relationship and function of INTC0, INTC1, and the GIC.
>>>> - Documentation and example refine.
>>>>
>>>> This enhances the documentation quality and helps developers
>>>> understand the interrupt controller hierarchy and usage.
>>>
>>> Changing ABI (compatibles) is not enhancing quality and is not explained here.
>>>
>> Sorry, I would add following in description.
>> - add 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible strings
>> for parent interrupt controller nodes, in addition to the existing
>> 'aspeed,ast2700-intc-ic' for child nodes.
>>
> 
> It does not say why is this needed in the first place...
> 
And also never tested :/. I won't be reviewing it.


Best regards,
Krzysztof