linux-kernel - Re: [PATCH v3 2/2] rust: update ARef and AlwaysRefCounted call sites to import from sync::aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBBNCQQ5HF3N.3HXQWJR71RZ8S@kernel.org>
Date: Mon, 14 Jul 2025 10:48:56 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Shankari Anand" <shankari.ak0208@...il.com>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>
Subject: Re: [PATCH v3 2/2] rust: update ARef and AlwaysRefCounted call
 sites to import from sync::aref

On Sun Jul 13, 2025 at 11:36 PM CEST, Shankari Anand wrote:
> Update call sites to import ARef and AlwaysRefCounted directly 
> from sync::aref instead of indirectly via types.
> Remove the re-export of their definitions in types.rs.
>
> Suggested-by: Benno Lossin <lossin@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@...il.com>
> ---
> v2 -> v3: solved the styling error triggered by the kernel bot.
> ---
>  drivers/block/rnull.rs               |  3 +--
>  drivers/gpu/drm/nova/driver.rs       |  4 +++-
>  drivers/gpu/drm/nova/gem.rs          |  2 +-
>  rust/kernel/auxiliary.rs             |  2 +-
>  rust/kernel/block/mq.rs              |  8 ++++----
>  rust/kernel/block/mq/operations.rs   |  2 +-
>  rust/kernel/block/mq/request.rs      |  3 ++-
>  rust/kernel/cred.rs                  |  6 +-----
>  rust/kernel/device.rs                | 10 +++-------
>  rust/kernel/devres.rs                |  3 +--
>  rust/kernel/dma.rs                   |  2 +-
>  rust/kernel/drm/device.rs            |  3 ++-
>  rust/kernel/drm/driver.rs            |  2 +-
>  rust/kernel/drm/gem/mod.rs           |  3 ++-
>  rust/kernel/fs/file.rs               |  3 ++-
>  rust/kernel/mm.rs                    |  3 ++-
>  rust/kernel/mm/mmput_async.rs        |  2 +-
>  rust/kernel/opp.rs                   | 13 +++++++------
>  rust/kernel/pci.rs                   |  5 +++--
>  rust/kernel/pid_namespace.rs         |  5 +----
>  rust/kernel/platform.rs              |  2 +-
>  rust/kernel/task.rs                  |  7 ++++---
>  rust/kernel/types.rs                 |  2 --
>  samples/rust/rust_dma.rs             |  2 +-
>  samples/rust/rust_driver_pci.rs      |  2 +-
>  samples/rust/rust_driver_platform.rs |  2 +-
>  samples/rust/rust_misc_device.rs     |  3 +--
>  27 files changed, 49 insertions(+), 55 deletions(-)

We probably want to split this by subsystem and not remove the
re-exports this cycle. @Miguel what do you think?

---
Cheers,
Benno