linux-kernel - Re: [PATCH 1/2] objtool/rust: add one more `noreturn` Rust function for Rust 1.89.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250714090143.GM1613200@noisy.programming.kicks-ass.net>
Date: Mon, 14 Jul 2025 11:01:43 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
	stable@...r.kernel.org
Subject: Re: [PATCH 1/2] objtool/rust: add one more `noreturn` Rust function
 for Rust 1.89.0

On Mon, Jul 14, 2025 at 10:48:33AM +0200, Alice Ryhl wrote:

> > >  tools/objtool/check.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > > index f23bdda737aa..3257eefc41ed 100644
> > > --- a/tools/objtool/check.c
> > > +++ b/tools/objtool/check.c
> > > @@ -224,6 +224,7 @@ static bool is_rust_noreturn(const struct symbol *func)
> > >              str_ends_with(func->name, "_4core9panicking14panic_explicit")                            ||
> > >              str_ends_with(func->name, "_4core9panicking14panic_nounwind")                            ||
> > >              str_ends_with(func->name, "_4core9panicking18panic_bounds_check")                        ||
> > > +            str_ends_with(func->name, "_4core9panicking18panic_nounwind_fmt")                        ||
> > >              str_ends_with(func->name, "_4core9panicking19assert_failed_inner")                       ||
> > >              str_ends_with(func->name, "_4core9panicking30panic_null_pointer_dereference")            ||
> > >              str_ends_with(func->name, "_4core9panicking36panic_misaligned_pointer_dereference")      ||
> >
> > Just having "_4core9panicking" substring is not sufficient?
> 
> That prefix just means it is defined in the panicking.rs file, which
> also has a few functions that are not noreturn.

Oh well, I figured it was too good to be true anyway. Its just that
there was a lot of that around and I had to ask :-)