linux-kernel - Re: [PATCH] wifi: mac80211: warn on insufficient antennas for injected HT frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a178703de98e87d9c046975de1b078086b7cf9f.camel@sipsolutions.net>
Date: Mon, 14 Jul 2025 11:47:09 +0200
From: Johannes Berg <johannes@...solutions.net>
To: WangYuli <wangyuli@...ontech.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	zhanjun@...ontech.com, niecheng1@...ontech.com, guanwentao@...ontech.com
Subject: Re: [PATCH] wifi: mac80211: warn on insufficient antennas for
 injected HT frames

On Mon, 2025-07-14 at 17:44 +0800, WangYuli wrote:
> When injecting frames via radiotap, an HT MCS rate can be specified.
> The number of chains for that MCS implies a minimum number of
> antennas that must be enabled in the antenna bitmap. Previously,
> if the antenna bitmap specified fewer antennas than required by the
> MCS, the bitmap was silently cleared. This makes it hard to debug
> issues with injected frames.
> 
> Add a WARN_ONCE() to log a descriptive error when this happens, make
> it clear that the antenna configuration was insufficient and has
> been reset.
> 

No. We shouldn't WARN on userspace misbehaviour.

johannes