linux-kernel - Re: [PATCH net-next v6 3/3] selftests: net: add netpoll basic functionality test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <v3tiskdekzcj4ra4pgd3wegz2wkafp5sfzber3e2i7unj72bsp@sywehjrf45xb>
Date: Mon, 14 Jul 2025 02:52:13 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, bpf@...r.kernel.org, kernel-team@...a.com, 
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next v6 3/3] selftests: net: add netpoll basic
 functionality test

Hello Jakub,

On Fri, Jul 11, 2025 at 10:14:15AM -0700, Jakub Kicinski wrote:
> On Fri, 11 Jul 2025 09:05:11 -0700 Breno Leitao wrote:
> > +        rxq = ethtool_result["rx"]
> > +        txq = ethtool_result["tx"]
> 
> Most HW NICs will actually use the "combined" channels (which have both
> rx and tx ring on one NAPI).

Right. I am getting combined as well. With the JSON output in ethtool,
I get;


        ethtool_result = ethtool(f"-l {interface_name}", json=True)[0]
        rxq = ethtool_result.get("rx", -1)
        txq = ethtool_result.get("tx", -1)
        combined = ethtool_result.get("combined", -1)

> > +    logging.debug("calling: ethtool %s", cmdline)
> 
> ksft_pr() ? 

ksft_pr() would make it very verbose. logging.debug() is always
disabled, so, the selftest executes cleanly.

> We had a plan to add a verbose() helper which would still be
> TAP-compatible, but never finished the patches.

I can try to help. How do you want to set verbose during the test
execution? Any shell environment variable?

> Either way, would you mind respinning the series (without the 24h wait)?
> It conflicts with another series which adds a bpftool() helper.
> I applied that patch so you should see a trivial conflict when rebasing.

Thanks. I am sending a new version assuming ethtool -l has the json
option. That would make the code simpler, given we don't need that hacky
to_int().

Thanks for the review,
--breno