linux-kernel - Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBBOW776RS0Z.1UZDHR9MGX26P@kernel.org>
Date: Mon, 14 Jul 2025 12:01:22 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Matthias Schiffer" <matthias.schiffer@...tq-group.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, "Rob Herring" <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Andy Whitcroft" <apw@...onical.com>
Cc: "Dwaipayan Ray" <dwaipayanray1@...il.com>, "Lukas Bulwahn"
 <lukas.bulwahn@...il.com>, "Joe Perches" <joe@...ches.com>, "Jonathan
 Corbet" <corbet@....net>, "Nishanth Menon" <nm@...com>, "Vignesh
 Raghavendra" <vigneshr@...com>, "Siddharth Vadapalli" <s-vadapalli@...com>,
 "Roger Quadros" <rogerq@...nel.org>, "Tero Kristo" <kristo@...nel.org>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux@...tq-group.com>, "Maxime
 Chevallier" <maxime.chevallier@...tlin.com>, "Andrew Lunn" <andrew@...n.ch>
Subject: Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY
 mode for fixed RGMII TX delay

Hi,

On Tue Jun 24, 2025 at 12:53 PM CEST, Matthias Schiffer wrote:
> All am65-cpsw controllers have a fixed TX delay, so the PHY interface
> mode must be fixed up to account for this.
>
> Modes that claim to a delay on the PCB can't actually work. Warn people
> to update their Device Trees if one of the unsupported modes is specified.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

For whatever reason, this patch is breaking network on our board
(just transmission). We have rgmii-id in our devicetree which is now
modified to be just rgmii-rxid. The board has a TI AM67A (J722S) with a
Broadcom BCM54210E PHY. I'm not sure, if AM67A MAC doesn't add any
delay or if it's too small. I'll need to ask around if there are any
measurements but my colleague doing the measurements is on holiday
at the moment.

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)