linux-kernel - Re: [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH3fRxgqhu2tDzshRi5MkV7DJk4iCDYE=x_hecWtBYWUpQ@mail.gmail.com>
Date: Mon, 14 Jul 2025 20:17:55 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Svyatoslav Ryhel <clamor95@...il.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors

Hi,

Applied it. Thanks.

On Fri, May 16, 2025 at 9:26 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
> subsequent build errors:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
>   Depends on [m]: I2C [=m]
>   Selected by [y]:
>   - EXTCON_MAX14526 [=y] && EXTCON [=y]
>
> ld: vmlinux.o: in function `max14526_driver_init':
> extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
> ld: vmlinux.o: in function `max14526_driver_exit':
> extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Svyatoslav Ryhel <clamor95@...il.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> ---
>  drivers/extcon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20250515.orig/drivers/extcon/Kconfig
> +++ linux-next-20250515/drivers/extcon/Kconfig
> @@ -136,6 +136,7 @@ config EXTCON_MAX8997
>
>  config EXTCON_MAX14526
>         tristate "Maxim MAX14526 EXTCON Support"
> +       depends on I2C
>         select IRQ_DOMAIN
>         select REGMAP_I2C
>         help
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics