linux-kernel - RE: [PATCH net-next 06/12] ptp: netc: add debugfs support to loop back pulse signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510CEA485EAE319AD743C728854A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Mon, 14 Jul 2025 02:33:21 +0000
From: Wei Fang <wei.fang@....com>
To: Andrew Lunn <andrew@...n.ch>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>, Clark
 Wang <xiaoning.wang@....com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "F.S. Peng"
	<fushi.peng@....com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH net-next 06/12] ptp: netc: add debugfs support to loop
 back pulse signal

> > +static void netc_timer_create_debugfs(struct netc_timer *priv)
> > +{
> > +	char debugfs_name[24];
> > +	struct dentry *root;
> > +
> > +	snprintf(debugfs_name, sizeof(debugfs_name), "netc_timer%d",
> > +		 priv->phc_index);
> > +	root = debugfs_create_dir(debugfs_name, NULL);
> > +	if (IS_ERR(root))
> > +		return;
> 
> You should never check the return values from a debugfs_
> calls. debugfs is full optional, and the driver should work without
> it. debugfs will also happily accept a NULL or error code as a
> parameter. So even if debugfs_create_dir() fails, keep going,
> debugfs_create_file() won't explode.
> 
You are right, I will remove the check, thanks