linux-kernel - Re: [PATCH v2] arm64: dts: qcom: x1e80100-crd: Add USB multiport fingerprint reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHT_VIKk1kvMgoM4@hovoldconsulting.com>
Date: Mon, 14 Jul 2025 15:00:04 +0200
From: Johan Hovold <johan@...nel.org>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Abel Vesa <abel.vesa@...aro.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-crd: Add USB multiport
 fingerprint reader

On Mon, Jul 14, 2025 at 01:48:15PM +0200, Stephan Gerhold wrote:
> The X1E80100 CRD has a Goodix fingerprint reader connected to the USB
> multiport controller on eUSB6. All other ports (including USB super-speed
> pins) are unused.
> 
> Set it up in the device tree together with the NXP PTN3222 repeater.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
> Changes in v2:
> - Describe all PHYs, also the unused ones (Johan)
> - Put #phy-cells property last (Johan)
> - Sort supplies alphabetically (Johan)
> - Johan suggested dropping output-low, but together with bias-disable this
>   would leave the line temporarily floating until the driver probes.
>   Perhaps dropping bias-disable would be better since it shouldn't make a
>   difference for output-only GPIOs(?), but for now keep it as-is to match
>   all other X1E devices.
> - Drop defconfig patch since Bjorn sent a different one that was applied
> - Link to v1: https://lore.kernel.org/r/20241118-x1e80100-crd-fp-v1-0-ec6b553a2e53@linaro.org

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
Tested-by: Johan Hovold <johan+linaro@...nel.org>