[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bbf76d81-fc5c-4234-951a-29b2e54b6603@kernel.org>
Date: Mon, 14 Jul 2025 15:08:21 +0200
From: Hans de Goede <hansg@...nel.org>
To: Ricardo Ribalda <ribalda@...omium.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
<hverkuil@...all.nl>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Linus Walleij
<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
"Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 03/12] ACPI: mipi-disco-img: Do not duplicate rotation
info into swnodes
Hi,
On 5-Jun-25 19:52, Ricardo Ribalda wrote:
> The function v4l2_fwnode_device_parse() is not capable of parsint the
> _PLD method, there is no need to duplicate the rotation information in a
> swnode.
>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@...nel.org>
with Sakari's review remarks addressed.
Regards,
Hans
> ---
> drivers/acpi/mipi-disco-img.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
> index 5b85989f96beeb726f59ac9e12e965a215fb38f6..b58b5ba22a47a4afc5212998074d322f0b7586dc 100644
> --- a/drivers/acpi/mipi-disco-img.c
> +++ b/drivers/acpi/mipi-disco-img.c
> @@ -617,21 +617,6 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2)
>
> adev_fwnode = acpi_fwnode_handle(adev);
>
> - /*
> - * If the "rotation" property is not present, but _PLD is there,
> - * evaluate it to get the "rotation" value.
> - */
> - if (!fwnode_property_present(adev_fwnode, "rotation")) {
> - struct acpi_pld_info *pld;
> -
> - if (acpi_get_physical_device_location(handle, &pld)) {
> - swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =
> - PROPERTY_ENTRY_U32("rotation",
> - pld->rotation * 45U);
> - kfree(pld);
> - }
> - }
> -
> if (!fwnode_property_read_u32(adev_fwnode, "mipi-img-clock-frequency", &val))
> swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_CLOCK_FREQUENCY)] =
> PROPERTY_ENTRY_U32("clock-frequency", val);
>
Powered by blists - more mailing lists