linux-kernel - Re: [PATCH 00/12] media: rkvdec: Add support for VDPU381 and VDPU383

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2229133.irdbgypaU6@trenzalore>
Date: Mon, 14 Jul 2025 09:35:19 -0400
From: Detlev Casanova <detlev.casanova@...labora.com>
To: Jianfeng Liu <liujianfeng1994@...il.com>
Cc: heiko@...ech.de, kernel@...labora.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 mchehab@...nel.org, nicolas.dufresne@...labora.com,
 nicolas.frattaroli@...labora.com
Subject: Re: [PATCH 00/12] media: rkvdec: Add support for VDPU381 and VDPU383

Hi Jianfeng,

On Sunday, 13 July 2025 10:25:14 EDT Jianfeng Liu wrote:
> Hi,
> 
> On Tue,  8 Jul 2025 11:19:33 -0400, Detlev Casanova wrote:
> >As there is a considerable part of the code that can be shared with the
> >already supported rkvdec decoder driver, the support for these variants
> >is added here rather than writing a new driver.
> 
> I have tested the new series on rk3588 and rk3399 with chromium. Since the
> HEVC decoder need EXT_SPS_RPS related patches, I ony test the H264 decoder.
> There are two issues:
> 
> 1, The decoder max size is detected 1920x1088, which should be the fallback
> size when queryig VIDIOC_ENUM_FRAMESIZES[1].

>From the linked code, the max size is hard coded to 1920x1088.
The driver sets the frame size type to V4L2_FRMSIZE_TYPE_CONTINUOUS, so the 
snippet you pointed to doesn't update the values for max/min. See [2] for the 
discussion about using V4L2_FRMSIZE_TYPE_CONTINUOUS.

> 2, Playing H264 videos ends up with green screen.

Can you elaborate a bit ? What videos ?
Is that on both SoCs ?
Is there any logs in dmesg ?

> These above issues don't happen with the old rkvdec2 series.
> 
> [1]
> https://github.com/chromium/chromium/blob/138.0.7204.92/media/gpu/v4l2/v4l2
> _utils.cc#L520-L533

[2] https://lore.kernel.org/all/c7882f94-e2cb-4023-a53e-87ebc8fa3460@gmail.com/

Regards,
Detlev