linux-kernel - Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3457ab8-8bb7-4a43-913e-2eb73149ff20@sirena.org.uk>
Date: Mon, 14 Jul 2025 14:39:59 +0100
From: Mark Brown <broonie@...nel.org>
To: wang lian <lianux.mm@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>, SeongJae Park <sj@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Zi Yan <ziy@...dia.com>, linux-kernel@...r.kernel.org,
	Christian Brauner <brauner@...nel.org>,
	Jann Horn <jannh@...gle.com>,
	Liam Howlett <Liam.Howlett@...cle.com>,
	Shuah Khan <shuah@...nel.org>, Vlastimil Babka <vbabka@...e.cz>,
	gkwang <gkwang@...x-info.com>, p1ucky0923 <p1ucky0923@...il.com>,
	ryncsn <ryncsn@...il.com>,
	"zijing . zhang" <zijing.zhang@...ton.me>,
	linux-kselftest@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] selftests/mm: refactor common code and improve test
 skipping in guard_region

On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote:

> Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared
> `vm_util.h` header to promote code reuse.
> 
> In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro
> to ensure only the current test is skipped on permission failure, instead
> of terminating the entire test binary.

These two changes look fine but they're not really related so should be
separate patches.  Looking briefly at guard-regions.c I see a bunch more
use of ksft_exit_ functions that ought to be fixed as well, but your fix
is good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)