linux-kernel - Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <380fb0f4-f5dd-47ad-92e3-943f30b08c31@kernel.org>
Date: Mon, 14 Jul 2025 16:04:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "F.S. Peng" <fushi.peng@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Clark Wang
 <xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC
 Timer

On 14/07/2025 15:43, Wei Fang wrote:
>> On 14/07/2025 12:28, Wei Fang wrote:
>>>>>
>>>>> Currently, the enetc driver uses the PCIe device number and function
>> number
>>>>> of the Timer to obtain the Timer device, so there is no related binding in
>> DTS.
>>>>
>>>> So you just tightly coupled these devices. Looks poor design for me, but
>>>> your choice. Anyway, then use that channel as information to pass the
>>>> pin/timer/channel number. You do not get a new property for that.
>>>>
>>>
>>> I do not understand, the property is to indicate which pin the board is
>>> used to out PPS signal, as I said earlier, these pins are multiplexed with
>>
>> Sure, I get it and my argument for phandle cells stays. If you decide
>> not to use it, you do not get a new property.
> 
> I do not know how to add the phandle cells, a phandle value is a way to
> reference another node in the DTS. But for the NETC Timer, what node
> does it need to reference? To be honest, I have no idea.

I don't think you tried hard enough... I asked to read other bindings.
If you did that, you would notice timestamper property and argument.

Best regards,
Krzysztof