linux-kernel - Re: [PATCH] mm/vma: refactor vma_modify_flags_name() to vma_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee19189f-7510-4ddd-85b0-34d6319f8fc6@redhat.com>
Date: Mon, 14 Jul 2025 16:18:13 +0200
From: David Hildenbrand <david@...hat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
 Pedro Falcato <pfalcato@...e.de>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vma: refactor vma_modify_flags_name() to
 vma_modify_name()

On 14.07.25 15:58, Lorenzo Stoakes wrote:
> The single instance in which we use this function doesn't actually need to
> change VMA flags, so remove this parameter and update the caller
> accordingly.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---
>   mm/madvise.c |  4 ++--
>   mm/vma.c     |  4 +---
>   mm/vma.h     | 15 +++++++--------
>   3 files changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 9de9b7c797c6..afa9e4db2adb 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -162,8 +162,8 @@ static int madvise_update_vma(vm_flags_t new_flags,
>   		return 0;
>   
>   	if (set_new_anon_name)
> -		vma = vma_modify_flags_name(&vmi, madv_behavior->prev, vma,
> -			range->start, range->end, new_flags, anon_name);
> +		vma = vma_modify_name(&vmi, madv_behavior->prev, vma,
> +			range->start, range->end, anon_name);
>   	else

The doc of madvise_update_vma() is a bit misleading:

"Update the vm_flags and/or anon_name"

I assume it's xor? Do we want to sanity check that this will hold true?

In general, LGTM.

-- 
Cheers,

David / dhildenb