linux-kernel - Re: [PATCH v2] pmdomain: ti: Select PM_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715134814.zrensaf3o6yxjrgz@bogged>
Date: Tue, 15 Jul 2025 08:48:14 -0500
From: Nishanth Menon <nm@...com>
To: Guillaume La Roque <glaroque@...libre.com>
CC: <vigneshr@...com>, Ulf Hansson <ulf.hansson@...aro.org>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <vishalm@...com>, <matthias.schiffer@...tq-group.com>
Subject: Re: [PATCH v2] pmdomain: ti: Select PM_GENERIC_DOMAINS

On 10:50-20250715, Guillaume La Roque wrote:
> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
> it is always enabled when TI_SCI_PM_DOMAINS is selected.
> Since PM_GENERIC_DOMAINS is an implicit symbol, it can only be enabled
> through 'select' and cannot be explicitly enabled in configuration.
> This simplifies the dependency chain and prevents build issues
> 
> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> ---
> Changes in v2:
> - update commit message
> - fix select rules
> - Link to v1: https://lore.kernel.org/r/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com
> ---
>  drivers/pmdomain/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
> index 67c608bf7ed0..5386b362a7ab 100644
> --- a/drivers/pmdomain/ti/Kconfig
> +++ b/drivers/pmdomain/ti/Kconfig
> @@ -10,7 +10,7 @@ if SOC_TI
>  config TI_SCI_PM_DOMAINS
>  	tristate "TI SCI PM Domains Driver"
>  	depends on TI_SCI_PROTOCOL
> -	depends on PM_GENERIC_DOMAINS
> +	select PM_GENERIC_DOMAINS if PM
>  	help
>  	  Generic power domain implementation for TI device implementing
>  	  the TI SCI protocol.
> 
> ---
> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
> change-id: 20250704-depspmdomain-2c584745dca8
> 
> Best regards,
> -- 
> Guillaume La Roque <glaroque@...libre.com>
> 


Reviewed-by: Nishanth Menon <nm@...com>

Ulf, I am hoping we can queue this up for 6.17, I know it has been a bit
late :(

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource