linux-kernel - Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202507151015.GPkeA21H-lkp@intel.com>
Date: Tue, 15 Jul 2025 10:26:34 +0800
From: kernel test robot <lkp@...el.com>
To: aspeedyh <yh_chung@...eedtech.com>, jk@...econstruct.com.au,
	matt@...econstruct.com.au, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, bmc-sw@...eedtech.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

Hi aspeedyh,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]
[also build test WARNING on net/main linus/master v6.16-rc6 next-20250714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/aspeedyh/net-mctp-Add-MCTP-PCIe-VDM-transport-driver/20250714-142656
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250714062544.2612693-1-yh_chung%40aspeedtech.com
patch subject: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250715/202507151015.GPkeA21H-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250715/202507151015.GPkeA21H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507151015.GPkeA21H-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/mctp/mctp-pcie-vdm.c:491:4: warning: variable 'vdm_dev' is uninitialized when used here [-Wuninitialized]
     491 |                  vdm_dev->ndev->name);
         |                  ^~~~~~~
   include/linux/printk.h:631:26: note: expanded from macro 'pr_debug'
     631 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |                                 ^~~~~~~~~~~
   include/linux/dynamic_debug.h:270:22: note: expanded from macro 'dynamic_pr_debug'
     270 |                            pr_fmt(fmt), ##__VA_ARGS__)
         |                                           ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   drivers/net/mctp/mctp-pcie-vdm.c:484:35: note: initialize the variable 'vdm_dev' to silence this warning
     484 |         struct mctp_pcie_vdm_dev *vdm_dev;
         |                                          ^
         |                                           = NULL
   1 warning generated.


vim +/vdm_dev +491 drivers/net/mctp/mctp-pcie-vdm.c

   481	
   482	static void mctp_pcie_vdm_uninit(struct net_device *ndev)
   483	{
   484		struct mctp_pcie_vdm_dev *vdm_dev;
   485	
   486		struct mctp_pcie_vdm_route_info *route;
   487		struct hlist_node *tmp;
   488		int bkt;
   489	
   490		pr_debug("%s: uninitializing vdm_dev %s\n", __func__,
 > 491			 vdm_dev->ndev->name);
   492	
   493		vdm_dev = netdev_priv(ndev);
   494		vdm_dev->callback_ops->uninit(vdm_dev->dev);
   495	
   496		hash_for_each_safe(vdm_dev->route_table, bkt, tmp, route, hnode) {
   497			hash_del(&route->hnode);
   498			kfree(route);
   499		}
   500	
   501		if (vdm_dev->tx_thread) {
   502			kthread_stop(vdm_dev->tx_thread);
   503			vdm_dev->tx_thread = NULL;
   504		}
   505	
   506		if (mctp_pcie_vdm_wq) {
   507			cancel_work_sync(&vdm_dev->rx_work);
   508			flush_workqueue(mctp_pcie_vdm_wq);
   509			destroy_workqueue(mctp_pcie_vdm_wq);
   510			mctp_pcie_vdm_wq = NULL;
   511		}
   512	
   513		while (__ptr_ring_peek(&vdm_dev->tx_queue)) {
   514			struct sk_buff *skb;
   515	
   516			skb = ptr_ring_consume(&vdm_dev->tx_queue);
   517	
   518			if (skb)
   519				kfree_skb(skb);
   520		}
   521	
   522		mutex_lock(&mctp_pcie_vdm_dev_mutex);
   523		list_del(&vdm_dev->list);
   524		mutex_unlock(&mctp_pcie_vdm_dev_mutex);
   525	}
   526	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki