linux-kernel - Re: [PATCH v3 0/9] vsock/virtio: SKB allocation improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHZuNFIYR1g8h_-F@willie-the-truck>
Date: Tue, 15 Jul 2025 16:05:24 +0100
From: Will Deacon <will@...nel.org>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: linux-kernel@...r.kernel.org, Keir Fraser <keirf@...gle.com>,
	Steven Moreland <smoreland@...gle.com>,
	Frederick Mayle <fmayle@...gle.com>,
	Stefan Hajnoczi <stefanha@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	netdev@...r.kernel.org, virtualization@...ts.linux.dev
Subject: Re: [PATCH v3 0/9] vsock/virtio: SKB allocation improvements

On Tue, Jul 15, 2025 at 12:01:56PM +0200, Stefano Garzarella wrote:
> On Mon, Jul 14, 2025 at 04:20:54PM +0100, Will Deacon wrote:
> > Hi folks,
> > 
> > Here is version three of the patches I previously posted here:
> > 
> >  v1: https://lore.kernel.org/r/20250625131543.5155-1-will@kernel.org
> >  v2: https://lore.kernel.org/r/20250701164507.14883-1-will@kernel.org
> > 
> > Changes since v2 include:
> > 
> >  * Pass payload length as a parameter to virtio_vsock_skb_put()
> > 
> >  * Reinstate VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE based on a 4KiB total
> >    allocation size
> > 
> >  * Split movement of bounds check into a separate patch
> > 
> > Thanks again to Stefano for all the review feedback so far.
> 
> Thanks for the series!
> I left just a small comment on a patch, the rest LGTM!
> 
> I run my test suite without any issue!

Thank, Stefano. I'll send a v4 later this week with your R-b tags and
an unlikely() in the second patch.

Will