linux-kernel - Re: [PATCH 1/2] rust: alloc: specify the minimum alignment of each allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBCR6O0P8QSZ.30WTN1G293YC4@kernel.org>
Date: Tue, 15 Jul 2025 18:01:44 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Alice Ryhl" <aliceryhl@...gle.com>, "Lorenzo Stoakes"
 <lorenzo.stoakes@...cle.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>, "Danilo Krummrich"
 <dakr@...nel.org>, "Matthew Wilcox" <willy@...radead.org>, "Tamir
 Duberstein" <tamird@...il.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Miguel Ojeda" <ojeda@...nel.org>
Cc: "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Trevor Gross"
 <tmgross@...ch.edu>, <linux-mm@...ck.org>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] rust: alloc: specify the minimum alignment of each
 allocator

On Tue Jul 15, 2025 at 3:46 PM CEST, Alice Ryhl wrote:
> The kernel's allocators sometimes provide a higher alignment than the
> end-user requested, so add a new constant on the Allocator trait to let
> the allocator specify what its minimum guaranteed alignment is.
>
> This allows the ForeignOwnable trait to provide a more accurate value of
> FOREIGN_ALIGN when using a pointer type such as Box, which will be
> useful with certain collections such as XArray that store its own data
> in the low bits of pointers.
>
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

With the wording changed according to Danilo's suggestion:

Reviewed-by: Benno Lossin <lossin@...nel.org>

---
Cheers,
Benno

> ---
>  rust/kernel/alloc.rs           | 8 ++++++++
>  rust/kernel/alloc/allocator.rs | 8 ++++++++
>  2 files changed, 16 insertions(+)