linux-kernel - Re: [PATCH] gpiolib: devres: release GPIOs in devm_gpiod_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b62c265aee13fb250aee653c1b1b627e977917f.camel@linaro.org>
Date: Tue, 15 Jul 2025 17:39:02 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
	 <brgl@...ev.pl>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Tudor Ambarus	
 <tudor.ambarus@...aro.org>, Peter Griffin <peter.griffin@...aro.org>, Will
 McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-gpio@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: devres: release GPIOs in devm_gpiod_put_array()

On Tue, 2025-07-15 at 17:00 +0100, André Draszik wrote:
> devm_gpiod_put_array() is meant to undo the effects of
> devm_gpiod_get_array() - in particular, it should release the GPIOs
> contained in the array acquired with the latter. It is meant to be the
> resource-managed version of gpiod_put_array(), and it should behave
> similar to the non-array version devm_gpiod_put().
> 
> Since commit d1d52c6622a6 ("gpiolib: devres: Finish the conversion to
> use devm_add_action()") it doesn't do that anymore, it just removes the
> devres action and frees associated memory, but it doesn't actually
> release the GPIOs.
> 
> Fix by switching from devm_remove_action() to devm_release_action(),
> which will in addition invoke the action to release the GPIOs.
> 
> Fixes: d1d52c6622a6 ("gpiolib: devres: Finish the conversion to use devm_add_action()")

The culprit only exists in 6.16-rc for now, and it shouldn't be
backported to older kernels, hence I didn't add CC: stable, hoping
the patch can make it into the 6.16 release

Please let me know if that is unlikely and I shall send a v2 with
Cc: stable instead.

Cheers,
Andre'