linux-kernel - Re: [PATCH v3 7/8] cxl/region: Consolidate cxl_decoder_kill_region() and cxl_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68768ad36e84f_2ead1009e@dwillia2-xfh.jf.intel.com.notmuch>
Date: Tue, 15 Jul 2025 10:07:31 -0700
From: <dan.j.williams@...el.com>
To: Dave Jiang <dave.jiang@...el.com>, Dan Williams
	<dan.j.williams@...el.com>, <linux-cxl@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>, Alison Schofield
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Ira
 Weiny" <ira.weiny@...el.com>, "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [PATCH v3 7/8] cxl/region: Consolidate cxl_decoder_kill_region()
 and cxl_region_detach()

Dave Jiang wrote:
> 
> 
> On 7/11/25 4:49 PM, Dan Williams wrote:
> > Both detach_target() and cxld_unregister() want to tear down a cxl_region
> > when an endpoint decoder is either detached or destroyed.
> > 
> > When a region is to be destroyed cxl_region_detach() releases
> > cxl_region_rwsem unbinds the cxl_region driver and re-acquires the rwsem.
> > 
> 
> I think this one needs some commas?
> 
> When a region is to be destroyed cxl_region_detach() releases
> cxl_region_rwsem, unbinds the cxl_region driver, and re-acquires the rwsem.

Yes, modulo whether you believe in that last Oxford comma.