linux-kernel - Re: [PATCH] media: uvcvideo: Fix assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250715184257.GM20231@pendragon.ideasonboard.com>
Date: Tue, 15 Jul 2025 21:42:57 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Darshan Rathod <darshanrathod475@...il.com>
Cc: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Fix assignment in if condition

Hi Darshan,

Thank you for the patch.

On Tue, Jul 15, 2025 at 11:30:56AM +0000, Darshan Rathod wrote:
> The function uvc_input_init() used an assignment of the return value

s/used/uses/

> of input_register_device() within the condition of an if statement.
> 
> This coding style is discouraged by the Linux kernel coding style guide
> as it can be confused with a comparison and hide potential bugs.
> The checkpatch.pl script flags this as an error:
> "ERROR: do not use assignment in if condition"
> 
> Separate the assignment into its own statement before the conditional
> check to improve code readability and adhere to the kernel's
> coding standards.
> 
> Signed-off-by: Darshan Rathod <darshanrathod475@...il.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

I'll update the commit message as mentioned above when applying, no need
for a v2.

> ---
>  drivers/media/usb/uvc/uvc_status.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_status.c b/drivers/media/usb/uvc/uvc_status.c
> index ee01dce4b783..3c29c0bb3f7c 100644
> --- a/drivers/media/usb/uvc/uvc_status.c
> +++ b/drivers/media/usb/uvc/uvc_status.c
> @@ -62,7 +62,8 @@ static int uvc_input_init(struct uvc_device *dev)
>  	__set_bit(EV_KEY, input->evbit);
>  	__set_bit(KEY_CAMERA, input->keybit);
>  
> -	if ((ret = input_register_device(input)) < 0)
> +	ret = input_register_device(input);
> +	if (ret < 0)
>  		goto error;
>  
>  	dev->input = input;

-- 
Regards,

Laurent Pinchart