linux-kernel - Re: [PATCH v13] vhost: Reintroduces support of kthread API and adds mode selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dd21a72-9451-4b77-9ab4-d9b31b408e25@web.de>
Date: Tue, 15 Jul 2025 20:43:45 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Cindy Lu <lulu@...hat.com>, virtualization@...ts.linux-foundation.org,
 netdev@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
 "Michael S. Tsirkin" <mst@...hat.com>,
 Mike Christie <michael.christie@...cle.com>,
 Nicolas Dichtel <nicolas.dichtel@...nd.com>,
 Stefano Garzarella <sgarzare@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13] vhost: Reintroduces support of kthread API and adds
 mode selection

> This patch reintroduces kthread mode for vhost workers and provides
> configuration to select between kthread and task worker.
…

Is there a need to reconsider the relevance once more for the presented
cover letter?

…
> +++ b/drivers/vhost/vhost.c
…
> +static int vhost_attach_task_to_cgroups(struct vhost_worker *worker)
> +{
…
> +	vhost_worker_queue(worker, &attach.work);
> +
> +	mutex_lock(&worker->mutex);
…
> +	worker->attachment_cnt = saved_cnt;
> +
> +	mutex_unlock(&worker->mutex);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&worker->mutex);”?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225

Regards,
Markus