| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202507151101.012avOrF-lkp@intel.com>
Date: Tue, 15 Jul 2025 11:18:46 +0800
From: kernel test robot <lkp@...el.com>
To: Alex Deucher <alexander.deucher@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Prike Liang <Prike.Liang@....com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c:505:6-22: duplicated
argument to && or ||
Hi Alex,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 347e9f5043c89695b01e66b3ed111755afcf1911
commit: 42a66677805d03df9e2600fab82d0cbe855500e1 drm/amdgpu/userq: use consistent function naming
date: 3 months ago
config: arm-randconfig-r064-20250714 (https://download.01.org/0day-ci/archive/20250715/202507151101.012avOrF-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507151101.012avOrF-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c:505:6-22: duplicated argument to && or ||
vim +505 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 480
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 481 int amdgpu_userq_ioctl(struct drm_device *dev, void *data,
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 482 struct drm_file *filp)
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 483 {
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 484 union drm_amdgpu_userq *args = data;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 485 int r;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 486
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 487 switch (args->in.op) {
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 488 case AMDGPU_USERQ_OP_CREATE:
4ec2141d23d3bb drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 489 if (args->in.flags & ~(AMDGPU_USERQ_CREATE_FLAGS_QUEUE_PRIORITY_MASK |
4ec2141d23d3bb drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 490 AMDGPU_USERQ_CREATE_FLAGS_QUEUE_SECURE))
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 491 return -EINVAL;
42a66677805d03 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c Alex Deucher 2025-04-16 492 r = amdgpu_userq_create(filp, args);
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 493 if (r)
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 494 DRM_ERROR("Failed to create usermode queue\n");
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 495 break;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 496
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 497 case AMDGPU_USERQ_OP_FREE:
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 498 if (args->in.ip_type ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 499 args->in.doorbell_handle ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 500 args->in.doorbell_offset ||
fced8e7d2ddeba drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 501 args->in.flags ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 502 args->in.queue_va ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 503 args->in.queue_size ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 504 args->in.rptr_va ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 @505 args->in.wptr_va ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 506 args->in.wptr_va ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 507 args->in.mqd ||
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 508 args->in.mqd_size)
158bfbc72c5d76 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-26 509 return -EINVAL;
42a66677805d03 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c Alex Deucher 2025-04-16 510 r = amdgpu_userq_destroy(filp, args->in.queue_id);
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 511 if (r)
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 512 DRM_ERROR("Failed to destroy usermode queue\n");
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 513 break;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 514
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 515 default:
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 516 DRM_DEBUG_DRIVER("Invalid user queue op specified: %d\n", args->in.op);
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 517 return -EINVAL;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 518 }
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 519
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 520 return r;
5501117d24a38d drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2023-10-10 521 }
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 522 #else
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 523 int amdgpu_userq_ioctl(struct drm_device *dev, void *data,
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 524 struct drm_file *filp)
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 525 {
df85baa767ca39 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Alex Deucher 2025-02-28 526 return -ENOTSUPP;
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 527 }
f540f69256a3a0 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-27 528 #endif
bf33cb6551a8c5 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c Shashank Sharma 2024-08-26 529
:::::: The code at line 505 was first introduced by commit
:::::: 158bfbc72c5d7675039df540b120ccdd37bca5f0 drm/amdgpu: validate user queue parameters
:::::: TO: Alex Deucher <alexander.deucher@....com>
:::::: CC: Alex Deucher <alexander.deucher@....com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists