linux-kernel - Re: [PATCH v5 6/8] iommufd/selftest: Explicitly skip tests for inapplicable variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHaoRAfClCoCtm21@Asurada-Nvidia>
Date: Tue, 15 Jul 2025 12:13:08 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
CC: <jgg@...dia.com>, <jgg@...pe.ca>, <kevin.tian@...el.com>,
	<will@...nel.org>, <aneesh.kumar@...nel.org>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <joro@...tes.org>, <robin.murphy@....com>,
	<shuah@...nel.org>, <aik@....com>, <dan.j.williams@...el.com>,
	<baolu.lu@...ux.intel.com>, <yilun.xu@...el.com>
Subject: Re: [PATCH v5 6/8] iommufd/selftest: Explicitly skip tests for
 inapplicable variant

On Tue, Jul 15, 2025 at 02:32:43PM +0800, Xu Yilun wrote:

Two nits:

> +	test_ioctl_fault_alloc(&fault_id, &fault_fd);
> +	test_err_hwpt_alloc_iopf(ENOENT, dev_id, viommu_id, UINT32_MAX,
> +				 IOMMU_HWPT_FAULT_ID_VALID, &iopf_hwpt_id,
> +				 IOMMU_HWPT_DATA_SELFTEST, &data,
> +				 sizeof(data));

sizeof(data) could fit into previous line.

> +	test_cmd_hwpt_alloc_iopf(dev_id, viommu_id, fault_id,
> +				 IOMMU_HWPT_FAULT_ID_VALID, &iopf_hwpt_id,
> +				 IOMMU_HWPT_DATA_SELFTEST, &data,
> +				 sizeof(data));

Ditto

Thanks
Nicolin