linux-kernel - Re: [PATCH v1] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop nonexistent hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493da354-2c86-452b-b343-c9ecd3ff84e3@adomerle.pw>
Date: Tue, 15 Jul 2025 23:37:37 +0400
From: Arseniy Velikanov <me@...merle.pw>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Luka Panio <lukapanio@...il.com>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v1] arm64: dts: qcom: sm8250-xiaomi-pipa: Drop nonexistent
 hardware


On 15.07.2025 23:22, Dmitry Baryshkov wrote:
> On Tue, Jul 15, 2025 at 10:56:36PM +0400, Arseniy Velikanov wrote:
>> PM8009 was erroneously added since this device doesn't actually have it.
>> It triggers a big critical error at boot, so we're drop it.
> Might it be that there are different SKUs?
Well, while it's in dts, but it was disabled in the kernel config:
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/pipa-t-oss/arch/arm64/configs/vendor/pipa_user_defconfig#L413

Maybe they just forgot to remove it from dts (I still don't understand 
why it is displayed in i2cdetect though).
>
>> Also it looks like the fuel gauge is not connected to the battery,
>> it reports nonsense info. Downstream kernel uses pmic fg.
> Separate commit, please.
>
>> PMIC fuel-gauge driver uses mixed stats about dual-cell battery,
>> so I combined it into one.
>>
>> Fixes: 264beb3cbd0d ("arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree")
>>
>> Signed-off-by: Arseniy Velikanov <me@...merle.pw>
> Please remove empty line between tags (i.e. between Fixes and SoB).
>
>> ---
>>   .../boot/dts/qcom/sm8250-xiaomi-pipa.dts      | 95 +------------------
>>   1 file changed, 5 insertions(+), 90 deletions(-)
>>
>
---
Kind regards,
Arseniy.