linux-kernel - Re: cdrom: cdrom_mrw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <z64pki236n2mertom6jmgznj4t3dkxeosr56fhpmykjdrnzs2l@5xlhh7htcaw4>
Date: Tue, 15 Jul 2025 12:32:22 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Jens Axboe <axboe@...nel.dk>
Cc: Phillip Potter <phil@...lpotter.co.uk>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, Christoph Hellwig <hch@...radead.org>, 
	Chris Rankin <rankincj@...il.com>, linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: cdrom: cdrom_mrw_exit() NULL ptr deref

On (25/07/14 08:22), Jens Axboe wrote:
> This just looks totally broken, the cdrom layer trying to issue block
> layer commands at exit time. Perhaps something like the below (utterly
> untested) patch would be an improvement. Also gets rid of the silly
> ->exit() hook which exists just for mrw.

I don't have a CD/DVD drive to test this, but from what I can tell
the patch looks good to me.  Thanks for taking a look!