linux-kernel - Re: [PATCH 1/2] dt-bindings: nvmem: airoha: add SMC eFuses schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250715035233.GA7855-robh@kernel.org>
Date: Mon, 14 Jul 2025 22:52:33 -0500
From: Rob Herring <robh@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: airoha: add SMC eFuses schema

On Mon, Jul 14, 2025 at 05:13:46PM +0200, Christian Marangi wrote:
> Add Airoha SMC eFuses schema to document new Airoha SoC AN7581/AN7583
> way of accessing the 2 eFuse bank via the SMC command.
> 
> Each eFuse bank expose 64 eFuse cells of 32 bit used to give information
> on HW Revision, PHY Calibration,  Device Model, Private Key and
> all kind of other info specific to the SoC or the running system.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  .../bindings/nvmem/airoha,smc-efuses.yaml     | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
> new file mode 100644
> index 000000000000..399c3c14f6ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/airoha,smc-efuses.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha SMC eFuses
> +
> +description: |
> +  Airoha new SoC (AN7581/AN7583) expose banks of eFuse accessible
> +  via specific SMC commands.
> +
> +  2 different bank of eFuse or 64 cells of 32 bit are exposed
> +  read-only used to give information on HW Revision, PHY Calibration,
> +  Device Model, Private Key...
> +
> +maintainers:
> +  - Christian Marangi <ansuelsmth@...il.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - airoha,an7581-efuses
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  '^efuse-bank@[0-1]$':
> +    type: object
> +
> +    allOf:
> +      - $ref: nvmem.yaml#
> +
> +    properties:
> +      reg:
> +        description: Identify the eFuse bank. (0 or 1)

Drop "(0 or 1)". You say that here:

> +        enum: [0, 1]
> +
> +    required:
> +      - reg
> +
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    airoha-efuses {

efuse {

And put this under a /firmware node (not here, but in your .dts).

> +        compatible = "airoha,an7581-efuses";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        efuse-bank@0 {
> +           reg = <0>;
> +        };
> +    };
> +
> +...
> -- 
> 2.48.1
>