linux-kernel - Re: [PATCH v3] usb: dwc3: qcom: Remove extcon functionality from glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d1e5ac2-9bf1-4fe5-b832-2e438e51d7db@oss.qualcomm.com>
Date: Tue, 15 Jul 2025 09:48:13 +0530
From: Prashanth K <prashanth.k@....qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] usb: dwc3: qcom: Remove extcon functionality from glue



On 7/14/2025 8:59 PM, Prashanth K wrote:
> 
> 
> On 7/14/2025 10:17 AM, Krishna Kurapati wrote:
>> Deprecate usage of extcon functionality from the glue driver. Now
>> that the glue driver is a flattened implementation, all existing
>> DTs would eventually move to new bindings. While doing so let them
>> make use of role-switch/ typec frameworks to provide role data
>> rather than using extcon.
>>
>> On upstream, summary of targets/platforms using extcon is as follows:
>>
>> 1. MSM8916 and MSM8939 use Chipidea controller, hence the changes have no
>> effect on them.
>>
>> 2. Of the other extcon users, most of them use "linux,extcon-usb-gpio"
>> driver which relies on id/vbus gpios to inform role changes. This can be
>> transitioned to role switch based driver (usb-conn-gpio) while flattening
>> those platforms to move away from extcon and rely on role
>> switching.
>>
>> 3. The one target that uses dwc3 controller and extcon and is not based
>> on reading gpios is "arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi".
>> This platform uses TI chip to provide extcon. If usb on this platform is
>> being flattneed, then effort should be put in to define a usb-c-connector
>> device in DT and make use of role switch functionality in TUSB320L driver.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
>> ---
>> Changes in v3:
>> This change was 4rth patch in [1]. It was suggested to make this as the
>> first patch of the series. Since this is independent of role switch
>> patches, sending this out separately. Removed RB Tag of Dmitry since the
>> patch has been changed.
>>
>> [1]: https://lore.kernel.org/all/20250610091357.2983085-1-krishna.kurapati@oss.qualcomm.com/
>>
[...]
> 
> Shouldn't we cleanup the Kconfig also? Anyways it's not critical, so it
> can be handled in a follow-up patch if preferred.
> 
> config USB_DWC3_QCOM
> 		tristate "Qualcomm Platform"
> 		depends on ARCH_QCOM || COMPILE_TEST
> -		depends on EXTCON || !EXTCON
> 		depends on OF
> 

Ignore the above comment, both dwc3-qcom and dwc3-qcom-legacy uses same
config. Sorry for the spam!