linux-kernel - Re: [PATCH] lib/xxhash: Comment out unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHXwfyKRvXi5AZZT@infradead.org>
Date: Mon, 14 Jul 2025 23:09:03 -0700
From: Christoph Hellwig <hch@...radead.org>
To: linux@...blig.org
Cc: akpm@...ux-foundation.org, terrelln@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/xxhash: Comment out unused functions

On Mon, Jul 14, 2025 at 01:09:27AM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> xxh32_digest() and xxh32_update() were added in 2017 in the original
> xxhash commit, but have remained unused.
> 
> While I've mostly been deleting unused functions, this is a general
> library and I see erofs is using other bits of xxh32, so it didn't
> seem right just to delete them.
> 
> Comment them out with #if 0.
> (Which checkpatch rightly warns about)

Please just remove it like all other dead code.  The same argument
that folks can easily look at the git history to resurrect it applies
here as everywhere else.