linux-kernel - Re: [PATCH v1 1/1] string: Group str_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VezE_xG58zYkWJ3ohAX8HOMCDpz=8uJx+da2hKXLHgh+g@mail.gmail.com>
Date: Tue, 15 Jul 2025 09:53:42 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kees Cook <kees@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-hardening@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 1/1] string: Group str_has_prefix() and strstarts()

On Tue, Jul 15, 2025 at 9:52 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Tue, Jul 15, 2025 at 8:24 AM Kees Cook <kees@...nel.org> wrote:
> >
> > On Fri, Jul 11, 2025 at 11:55:14AM +0300, Andy Shevchenko wrote:
> > > The two str_has_prefix() and strstarts() are about the same
> > > with a slight difference on what they return. Group them in
> > > the header.
> >
> > It seems more like strstarts should just be a macro around
> > str_has_prefix() != 0?

Actually this won't work for len == 0, would it?

> This change is only about grouping, but if you think it worth
> modifying, I am not going to object. Just that I am about to have my
> vacation and I leave this as is for now. Up to you how to proceed.


-- 
With Best Regards,
Andy Shevchenko