linux-kernel - Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f79424f-0005-4978-8c6d-6b726ee7e4ab@linaro.org>
Date: Tue, 15 Jul 2025 09:06:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Vikash Garodia <quic_vgarodia@...cinc.com>, bryan.odonoghue@...aro.org,
 Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership
 by Bryan O'Donoghue

On 15/07/2025 09:00, Vikash Garodia wrote:
> 
> On 7/15/2025 12:14 PM, Krzysztof Kozlowski wrote:
>> On 15/07/2025 07:51, Vikash Garodia wrote:
>>>
>>> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>>>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>>>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>>>> in pull requests like [1]), so he is de facto the maintainer responsible
>>>> for the code.  Reflect this actual state my changing his entry from
>>>> reviewer to maintainer and moving the entry to alphabetical position by
>>>> first name.
>>>
>>> NAK.
>>>
>>> The roles and responsibilities are well agreed by media maintainer(Hans), with
>>> Bryan part of that discussion, w.r.t code contributions to iris and sending
>>> patches to media tree. The only reason Bryan post the patches is that Hans wants
>>> single PR for patches across Qualcomm media drivers (Camss/Videoss)
>>
>> That's the maintainer role, so Bryan is the maintainer. I am documenting
>> actual status and your NAK is naking what? That Bryan cannot handle patches?
> I would say, you are reading too much into it, i updated what we have discussed
> and agreed upon the different roles for managing venus and iris drivers.

Reading too much? Bryan HANDLES THE PATCHES.

That's it.

There is nothing "too much here".

Person handling the patches IS the maintainer. Full stop.

>>
>> Sorry, this is already happening.
>>
>> Your push back here is odd, impolite and really disappointing. You
>> actually should be happy that person outside wants to care about this
>> driver...
>>
>>> Hi Hans,
>>>
>>> Incase you would like to split sending PRs, as the contributions for Venus/Iris
>>> would be significantly higher, let us know, we can pick that up separately.
>>
>> Considering quality of the code you sent as Iris upstreaming, you are
>> not there yet.
> If you see the scope to improve the quality, you are always welcome to add
> patches to improve it.

I spoke about your work. You cannot use argument that you want to handle
patches regardless of quality of your code.

> 
> Regards,
> Vikash
>>
>> https://lore.kernel.org/all/1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com/

The one here.


Best regards,
Krzysztof