linux-kernel - Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHX-vyOnb-gZmsi1@hovoldconsulting.com>
Date: Tue, 15 Jul 2025 09:09:51 +0200
From: Johan Hovold <johan@...nel.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: fix OF node leak

On Mon, Jul 14, 2025 at 11:46:12AM -0700, Doug Anderson wrote:
> On Tue, Jul 8, 2025 at 1:52 AM Johan Hovold <johan@...nel.org> wrote:

> > Make sure to drop the OF node reference taken when creating the bridge
> > device when the device is later released.
> >
> > Fixes: a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev")
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> The patch doesn't apply to drm-misc-next, which has commit
> 6526b02e1020 ("drm/bridge: ti-sn65dsi86: use the auxiliary device").
> Seems like you need to resubmit as a patch to the new
> auxiliary_device_create() function?

I've already sent a fix for the generic implementation here:

	https://lore.kernel.org/lkml/20250708084654.15145-1-johan@kernel.org/

> Do you feel that this is urgent
> enough that we need a separate patch for stable?

No, we should be good then as I assume this bridge is typically
registered at boot and never deregistered (that's also why I left out
the stable tag).

Johan