linux-kernel - Re: [PATCH v2 0/2] Add Opaque::cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734axj4ak.fsf@kernel.org>
Date: Tue, 15 Jul 2025 09:34:27 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,  "Maxime
 Ripard" <mripard@...nel.org>,  "Thomas Zimmermann" <tzimmermann@...e.de>,
  "David Airlie" <airlied@...il.com>,  "Simona Vetter" <simona@...ll.ch>,
  "Miguel Ojeda" <ojeda@...nel.org>,  "Danilo Krummrich" <dakr@...nel.org>,
  "Boqun Feng" <boqun.feng@...il.com>,  "Gary Guo" <gary@...yguo.net>,
  Björn Roy Baron <bjorn3_gh@...tonmail.com>,  "Benno
 Lossin"
 <lossin@...nel.org>,  "Trevor Gross" <tmgross@...ch.edu>,
  <dri-devel@...ts.freedesktop.org>,  <rust-for-linux@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] Add Opaque::cast_from

"Alice Ryhl" <aliceryhl@...gle.com> writes:

> Since commit b20fbbc08a36 ("rust: check type of `$ptr` in
> `container_of!`") we have enforced that the field pointer passed to
> container_of! must match the declared field. This caused mismatches when
> using a pointer to bindings::x for fields of type Opaque<bindings::x>.
>
> This situation encourages the user to simply pass field.cast() to the
> container_of! macro, but this is not great because you might
> accidentally pass a *mut bindings::y when the field type is
> Opaque<bindings::x>, which would be wrong.
>
> To help catch this kind of mistake, add a new Opaque::cast_from that
> wraps a raw pointer in Opaque without changing the inner type. Also
> rename raw_get() to cast_into() for naming consistency.
>
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

I think your search/replace was a bit too general in hrtimer.rs. When
you fix that:

Acked-by: Andreas Hindborg <a.hindborg@...nel.org>


Best regards,
Andreas Hindborg