linux-kernel - drivers/gpu/drm/panel/panel-himax-hx8279.c:940:2-3: Unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202507150825.LZMhkNeK-lkp@intel.com>
Date: Tue, 15 Jul 2025 09:02:59 +0800
From: kernel test robot <lkp@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: drivers/gpu/drm/panel/panel-himax-hx8279.c:940:2-3: Unneeded
 semicolon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   347e9f5043c89695b01e66b3ed111755afcf1911
commit: 38d42c261389985e8dd4739dbd97e2dc855e8dd0 drm: panel: Add driver for Himax HX8279 DDIC panels
date:   3 months ago
config: arm-randconfig-r064-20250714 (https://download.01.org/0day-ci/archive/20250715/202507150825.LZMhkNeK-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507150825.LZMhkNeK-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/panel/panel-himax-hx8279.c:940:2-3: Unneeded semicolon

vim +940 drivers/gpu/drm/panel/panel-himax-hx8279.c

   895	
   896	static int hx8279_check_dig_gamma(struct hx8279 *hx, struct device *dev, const u8 *component)
   897	{
   898		u8 gamma_high_bits[4];
   899		u16 prev_val = 0;
   900		int i, j, k, x;
   901	
   902		/*
   903		 * The gamma values are 10 bits long and shall be incremental
   904		 * to form a digital gamma correction reference curve.
   905		 *
   906		 * As for the registers format: the first 24 bytes contain each the
   907		 * lowest 8 bits for each of the gamma level references, and the last
   908		 * 6 bytes contain the high two bits of 4 registers at a time, where
   909		 * the first two bits are relative to the last register, and the last
   910		 * two are relative to the first register.
   911		 *
   912		 * Another way of saying, those are the first four LOW values:
   913		 * DGMA1_LO = 0xb1, DGMA2_LO = 0xb2, DGMA3_LO = 0xb3, DGMA4_LO = 0xb4
   914		 *
   915		 * The high values for those four are at DGMA1_4_HI = 0xc9;
   916		 * ...and DGMA1_4_HI's data contains the following bits:
   917		 * [1:0] = DGMA4_HI, [3:2] = DGMA3_HI, [5:4] = DGMA2_HI, [7:6] = DGMA1_HI
   918		 */
   919		for (i = 0; i < HX8279_PG_DGAMMA_NUM_HI_BYTES; i++) {
   920			k = HX8279_PG_DGAMMA_NUM_LO_BYTES + i;
   921			j = i * 4;
   922			x = 0;
   923	
   924			gamma_high_bits[0] = FIELD_GET(HX8279_DGAMMA_DGMA1_HI, component[k]);
   925			gamma_high_bits[1] = FIELD_GET(HX8279_DGAMMA_DGMA2_HI, component[k]);
   926			gamma_high_bits[2] = FIELD_GET(HX8279_DGAMMA_DGMA3_HI, component[k]);
   927			gamma_high_bits[3] = FIELD_GET(HX8279_DGAMMA_DGMA4_HI, component[k]);
   928	
   929			do {
   930				u16 cur_val = component[j] | (gamma_high_bits[x] << 8);
   931	
   932				if (cur_val < prev_val)
   933					return dev_err_probe(dev, -EINVAL,
   934							     "Invalid dgamma values: %u < %u!\n",
   935							     cur_val, prev_val);
   936				prev_val = cur_val;
   937				j++;
   938				x++;
   939			} while (x < 4);
 > 940		};
   941	
   942		return 0;
   943	}
   944	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki